search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Check custom metrics only if running E2E tests #2214

Closed tommyreddad closed 3 years ago

tommyreddad commented 3 years ago

This unblocks #2212.

The "build" GitHub action has been changed to actually perform the build test. It ends up running our e2e tests a little bit and failing because the metrics client can't authenticate. This change makes it so the metrics check only runs when the e2e tests are running, not when the build test is running.

Tested with:

tags="$(grep -I  -r '// +build' . | \
      grep -v '^./vendor/' | \
      grep -v '^./hack/' | \
      grep -v '^./third_party' | \
      cut -f3 -d' ' | \
      sort | uniq | \
      grep -v '^!' | \
      tr '\n' ' ')"
go test -vet=off -tags "${tags}" -run=^$ ./...
coryrc commented 3 years ago

Revert the build test to the original too?

https://github.com/knative/serving/blob/main/.github/workflows/knative-go-build.yaml

coryrc commented 3 years ago

Revert the build test to the original too?

https://github.com/knative/serving/blob/main/.github/workflows/knative-go-build.yaml

Oh, I see that's the other change pending merge.

coryrc commented 3 years ago

/lgtm

knative-prow-robot commented 3 years ago

@coryrc: changing LGTM is restricted to collaborators

In response to [this](https://github.com/google/knative-gcp/pull/2214#issuecomment-840718930): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
eclipselu commented 3 years ago

/lgtm /approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eclipselu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [eclipselu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tommyreddad commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests