search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

Manual update dependency and use new upgrade test infra #2224

Closed zhongduo closed 3 years ago

zhongduo commented 3 years ago

The upgrade test infra has been updated, this PR changes to the latest infra.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from zhongduo after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhongduo commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests

zhongduo commented 3 years ago

it turns out that the upgrade test now use . in the name of the trigger, which will be copied as label in the pubsub topic as labels, but pubsub topic does not accept . in the label value.....

knative-prow-robot commented 3 years ago

@zhongduo: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-upgrade-tests 2fa30d15b6738e91bd6433033a44d68f9a6c4e89 link /test pull-google-knative-gcp-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
knative-prow-robot commented 3 years ago

@zhongduo: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.