search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Pin serving and eventing e2e test versions to 0.23 #2247

Closed tommyreddad closed 3 years ago

tommyreddad commented 3 years ago

Fixes the failing continuous and nightly release e2e tests, e.g., https://prow.knative.dev/view/gs/knative-prow/logs/ci-google-knative-gcp-nightly-release/1415605632215552000

The changes in https://github.com/knative/eventing/pull/5551 add a new status condition to triggers, which breaks our implementation, since we don't expect the new condition and our triggers are marked as Unknown. We should stop testing against eventing and serving nightly.

nlopezgi commented 3 years ago

/lgtm /approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, tommyreddad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [nlopezgi,tommyreddad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment