Fix build break on system without O_CLOEXEC

google / leveldb

LevelDB is a fast key-value storage library written at Google that provides an ordered mapping from string keys to string values.

BSD 3-Clause "New" or "Revised" License

35.71k stars 7.72k forks source link

Fix build break on system without O_CLOEXEC #1149

Open stepinto opened 9 months ago

stepinto commented 9 months ago

On system without O_CLOEXEC, HAVE_O_CLOEXEC is defined as 0 in include/port/port_config.h, not undefined. Therefore, the right way to test it is "#if HAVE_O_CLOEXEC" rather than "#if defined(...)".

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

hebasto commented 8 months ago

Also see https://github.com/google/leveldb/pull/1028.