Check return value of TableBuilder::Add() in compaction routine.

google / leveldb

LevelDB is a fast key-value storage library written at Google that provides an ordered mapping from string keys to string values.

BSD 3-Clause "New" or "Revised" License

35.71k stars 7.72k forks source link

Check return value of TableBuilder::Add() in compaction routine. #1179

Open evanstade opened 2 months ago

evanstade commented 2 months ago

This is a prospective fix for the crash described in crbug.com/326566884. Inspection of the crash dump suggests that Add() is failing, but the compaction routine is continuing to run. While it's not entirely clear how precisely this leads to the observed failure mode, it seems safer to check the status of the TableBuilder and abort early as needed.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.