google / leveldb

LevelDB is a fast key-value storage library written at Google that provides an ordered mapping from string keys to string values.
BSD 3-Clause "New" or "Revised" License
36.14k stars 7.78k forks source link

Support for DragonFlyBSD/NetBSD/OpenBSD #65

Closed cmumford closed 10 years ago

cmumford commented 10 years ago

Original issue 59 created by andrew@hijacked.us on 2011-12-03T03:42:50.000Z:

What steps will reproduce the problem?

  1. Try to compile on one of the above operating systems
  2. The compile will fail because of missing includes and missing fdatasync, etc

What is the expected output? What do you see instead?

leveldb should compile correctly, instead it fails.

Please provide any additional information below.

Patch is attached. This supersedes issue 31.

cmumford commented 10 years ago

Comment #1 originally posted by piotr.sikora@frickle.com on 2011-12-13T06:32:39.000Z:

Andrew, there are two bugs in your patch: 1) OpenBSD is using "-lpthread" instead of "-pthread" (like it was in patch for # 31), 2) DragonFly defines PLATFORM=OS_OPENBSD.

cmumford commented 10 years ago

Comment #2 originally posted by andrew@hijacked.us on 2011-12-17T04:37:12.000Z:

Updated patch.

cmumford commented 10 years ago

Comment #3 originally posted by andrew@hijacked.us on 2012-03-01T14:11:34.000Z:

Is this ever going to go anywhere?

cmumford commented 10 years ago

Comment #4 originally posted by sanjay@google.com on 2012-03-05T18:40:31.000Z:

Fixed.

cmumford commented 10 years ago

Comment #5 originally posted by dgrogan@chromium.org on 2012-06-01T23:57:04.000Z:

Issue 31 has been merged into this issue.