cmumford
commented
10 years ago Comment #1 originally posted by sanjay@google.com on 2012-04-25T16:55:07.000Z:
Seems to me like your port doesn't have the correct value for port::kLittleEndian and therefore the routines in coding.{h,cc} are not working correctly.
To verify this:
(a) Print port::kLittleEndian at the beginning of some test It should be false on your machine, but if my hypothesis is correct, it will be true.
(b) Add the following test to coding_test and see if it works:
// Test that encoding routines generate little-endian encodings
TEST(Coding, EncodingOutput) {
std::string dst;
PutFixed32(&dst, 0x04030201);
ASSERT_EQ(4, dst.size());
ASSERT_EQ(0x01, static_cast
dst.clear();
PutFixed64(&dst, 0x0807060504030201);
ASSERT_EQ(8, dst.size());
ASSERT_EQ(0x01, static_cast
(c) I suspect the endian detection logic in port/port_posix.h is wrong (it is seeing a name-clash between its use of LITTLE_ENDIAN and some header file also defining it). Try applying the following patch:
--- /tmp/port/port_posix.h# 30 2012-03-05 10:18:09.000000000 -0800 +++ port/port_posix.h 2012-04-25 09:52:04.835123000 -0700 @@ -7,14 +7,15 @@
ifndef STORAGE_LEVELDB_PORT_PORT_POSIXH
define STORAGE_LEVELDB_PORT_PORT_POSIXH
+#undef PLATFORM_IS_LITTLE_ENDIAN
if defined(OS_MACOSX)
include <machine/endian.h>
elif defined(OS_SOLARIS)
include <sys/isa_defs.h>
ifdef _LITTLE_ENDIAN
-
define LITTLE_ENDIAN
-
define PLATFORM_IS_LITTLE_ENDIAN true
else
-
define BIG_ENDIAN
-
define PLATFORM_IS_LITTLE_ENDIAN false
endif
elif defined(OS_FREEBSD) || defined(OS_OPENBSD) || defined(OS_NETBSD) ||\
defined(OS_DRAGONFLYBSD) @@ -31,10 +32,8 @@
include
include "storage/leveldb/port/atomic_pointer.h"
-#ifdef LITTLE_ENDIAN -#define IS_LITTLE_ENDIAN true -#else -#define IS_LITTLE_ENDIAN (BYTE_ORDER == __LITTLE_ENDIAN) +#ifndef PLATFORM_IS_LITTLE_ENDIAN +#define PLATFORM_IS_LITTLE_ENDIAN (BYTE_ORDER == __LITTLE_ENDIAN)
endif
if defined(OS_MACOSX) || defined(OS_SOLARIS) || defined(OS_FREEBSD) ||\
@@ -54,7 +53,8 @@ namespace leveldb { namespace port {
-static const bool kLittleEndian = IS_LITTLE_ENDIAN; +static const bool kLittleEndian = PLATFORM_IS_LITTLE_ENDIAN; +#undef PLATFORM_IS_LITTLE_ENDIAN
class CondVar;
Original issue 85 created by jschindele@arcor.de on 2012-04-24T13:47:57.000Z:
it seems that CRC32c calculation fails on MCP83xx embedded processor! when i call "crc32c_test" the third test fails with different output than on i386 workstation. I added some printfs to visualize (see attached patch).
I compile with a toolchain from openwrt with following options "powerpc-openwrt-linux-gnu-g++ -mcpu=e300c3 -mbig-endian"
./crc32c_test ==== Test CRC.StandardResults calc CRC over data @ 0x0xbfab6358 len 32 result 8a9136aa calc CRC over data @ 0x0xbfab6358 len 32 result 62a8ab43 calc CRC over data @ 0x0xbfab6358 len 32 result 67022fc1 util/crc32c_test.cc:26: failed: 1188919630 == 1728196545
the same code compiled on openSuse i386 Worktation works fine without any failure.
the same Problem with db_bench command which fails after some steps.
./db_bench LevelDB: version 1.4 Date: Tue Apr 24 15:22:40 2012 CPU: 0 * CPUCache: Keys: 16 bytes each Values: 100 bytes each (50 bytes after compression) Entries: 1000000 RawSize: 110.6 MB (estimated) FileSize: 62.9 MB (estimated) WARNING: Snappy compression is not enabled ------------------------------------------------ calc CRC over data @ 0x0xbf96b7c8 len 1 result 527d5351 calc CRC over data @ 0x0xbf96b7c8 len 1 result a016d052 calc CRC over data @ 0x0xbf96b7c8 len 1 result b34623a6 calc CRC over data @ 0x0xbf96b7c8 len 1 result 412da0a5 calc CRC over data @ 0x0xbf96b7c8 len 1 result 95e7c44e calc CRC over data @ 0x0x1005def4 len 34 result 47a1355b calc CRC over data @ 0x0x1005e0ae len 35 result 37c0e56f checksum actual 0x37c0e56f masked 0x6d615a59 expected 0xa71abbfb (0x7ae836c1)open error: Corruption: checksum mismatch