search

google / libaddressinput

Google’s postal address library, powering Android and Chromium
Apache License 2.0
576 stars 104 forks source link

Make size.h compatible with libc++ on Windows. #153

Closed pcc closed 6 years ago

pcc commented 6 years ago

We cannot solely rely on the value of _MSC_VER when determining whether the standard library provides a definition of std::size; we also need to make sure that the standard library is not libc++.

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot commented 6 years ago

CLAs look good, thanks!