search

google / libultrahdr

Ultra HDR is a true HDR image format, and is backcompatible. libultrahdr is the reference codec for the Ultra HDR format. The codecs that support the format can render the HDR intent of the image on HDR displays; other codecs can still decode and display the SDR intent of the image.
https://developer.android.com/guide/topics/media/platform/hdr-image-format
Apache License 2.0
152 stars 27 forks source link

Encode Scenario 4 : Missing Parameters #157

Closed pmonck closed 3 months ago

pmonck commented 4 months ago

Using the example command: ultrahdr_app -m 0 -i cosmat_1920x1080_420_8bit.jpg -g cosmat_1920x1080_420_8bit.jpg -f metadata.cfg

results in: did not receive valid image width for encoding. width : 0

It looks like the example should be modified to include width (-w) and height (-h) parameters as in the other encode scenarios.

DichenZhang1 commented 4 months ago

Hi @pmonck,

Thank you for raising this issue! The width/height should be read from in input JPEG images instead of reading from the configuration. However, this indeed a bug in the app, and it should be fixed by https://github.com/google/libultrahdr/pull/159

Thank you!

DichenZhang1 commented 3 months ago

Close for now. Please re-open if there is further issue. Thank you!

pmonck commented 2 months ago

This issue seems to have reverted in the latest commit.

ram-mohan commented 2 months ago

looks like these changes were never merged in main. They were accidentally merged to a dev branch and the issue got closed.

pmonck commented 2 months ago

Thanks for looking into this. How should the issue be resolved?