fix: align xticks in barplot with multiple labels

google / lightweight_mmm

LightweightMMM 🦇 is a lightweight Bayesian Marketing Mix Modeling (MMM) library that allows users to easily train MMMs and obtain channel attribution information.

https://lightweight-mmm.readthedocs.io/en/latest/index.html

Apache License 2.0

829 stars 172 forks source link

fix: align xticks in barplot with multiple labels #260

Closed MarkusSagen closed 8 months ago

MarkusSagen commented 8 months ago

Fixes the alignments of the xticks when there are multiple bars in the barplot

Before

After

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

michevan commented 8 months ago

thank you for submitting this! I wanted to share that our team has just implemented the change, it's in this commit.

MarkusSagen commented 8 months ago

Nice! Are there other things or open PRs that I could work on then?

MarkusSagen commented 8 months ago

@michevan It seems that the PR that was merged is a line for line copy of this PR. Is there a particular policy for Google open-source or this project?