Fix comparison between 'char' and 'signed char'

google / lldb-eval

lldb-eval is a library for evaluating expressions in the debugger context

Apache License 2.0

72 stars 17 forks source link

Fix comparison between 'char' and 'signed char' #173

Closed tonkosi closed 2 years ago

github-actions[bot] commented 2 years ago

Benchmark comparison for ccf5f74d (base) vs 17a30bdc (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   -0.0070         -0.0066        118380        117547        118294        117511
BM/ArrayDereference                +0.0095         +0.0095        119007        120133        118989        120125
BM/ArraySubscript                  +0.0017         +0.0018        156707        156979        156690        156966
BM/TypeCasting                     -0.0008         -0.0008        419399        419043        419363        419015
BM/ParseInteger                    -0.0131         -0.0132        178346        176018        178332        175979

github-actions[bot] commented 2 years ago

Benchmark comparison for ccf5f74d (base) vs b7c8c8be (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   +0.1695         +0.1692        110558        129301        110512        129214
BM/ArrayDereference                +0.0483         +0.0487        120529        126351        120475        126342
BM/ArraySubscript                  -0.0062         -0.0062        159883        158894        159869        158882
BM/TypeCasting                     +0.0020         +0.0020        423205        424043        423166        423994
BM/ParseInteger                    -0.0674         -0.0677        187820        175170        187803        175086

github-actions[bot] commented 2 years ago

Benchmark comparison for ee1c7bd8 (base) vs df74444d (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   +0.0230         +0.0255        119333        122077        118996        122030
BM/ArrayDereference                +0.0204         +0.0204        120158        122613        120148        122604
BM/ArraySubscript                  +0.0071         +0.0065        160962        162098        160947        161996
BM/TypeCasting                     +0.0002         +0.0001        423180        423246        423120        423183
BM/ParseInteger                    +0.0271         +0.0274        178364        183204        178307        183185

github-actions[bot] commented 2 years ago

Benchmark comparison for ee1c7bd8 (base) vs 96250713 (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   +0.0203         +0.0189        116181        118539        116159        118349
BM/ArrayDereference                +0.0152         +0.0149        119486        121306        119472        121253
BM/ArraySubscript                  +0.0076         +0.0076        156547        157736        156530        157723
BM/TypeCasting                     +0.0063         +0.0060        414989        417618        414945        417439
BM/ParseInteger                    +0.0038         +0.0037        176005        176674        175988        176641

github-actions[bot] commented 2 years ago

Benchmark comparison for ee1c7bd8 (base) vs 2166ca0e (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   +0.0198         +0.0169        171391        174777        171214        174105
BM/ArrayDereference                -0.0128         -0.0127        181367        179053        181346        179041
BM/ArraySubscript                  -0.0185         -0.0188        227248        223049        227220        222948
BM/TypeCasting                     -0.0061         -0.0060        541966        538658        541862        538608
BM/ParseInteger                    +0.0172         +0.0171        235986        240042        235906        239942