Fix evaluation in the reference value context

google / lldb-eval

lldb-eval is a library for evaluating expressions in the debugger context

Apache License 2.0

72 stars 17 forks source link

Fix evaluation in the reference value context #183

Closed tonkosi closed 2 years ago

tonkosi commented 2 years ago

Fixes the following when evaluating in a reference value context (e.g. Object &):

this keyword,
static member access (lldb-eval used to look for Object &::static_member instead of Object::static_member)

github-actions[bot] commented 2 years ago

Benchmark comparison for 80505946 (base) vs 9693e052 (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   -0.0163         -0.0163        116228        114337        116208        114313
BM/ArrayDereference                +0.0014         +0.0015        118211        118378        118170        118350
BM/ArraySubscript                  -0.0000         +0.0006        153866        153861        153753        153842
BM/TypeCasting                     -0.0095         -0.0096        348730        345410        348706        345375
BM/ParseInteger                    -0.0027         -0.0027        105849        105561        105839        105552

github-actions[bot] commented 2 years ago

Benchmark comparison for 80505946 (base) vs 71961af9 (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   -0.0096         -0.0069        137186        135873        136788        135838
BM/ArrayDereference                +0.0051         +0.0047        139155        139863        139133        139794
BM/ArraySubscript                  +0.0042         +0.0035        182150        182907        182136        182776
BM/TypeCasting                     -0.0031         -0.0032        408883        407596        408833        407535
BM/ParseInteger                    -0.0123         -0.0122        127382        125818        127368        125810