Automatic landing of patches after successful builds

google / llvm-premerge-checks

CI system for premerge-testing in LLVM project

Apache License 2.0

41 stars 37 forks source link

Automatic landing of patches after successful builds #185

Open ChristianKuehnel opened 4 years ago

ChristianKuehnel commented 4 years ago

Idea:

Once a patch is ready to be landed, the user sets the "autoland" flag on a Revision.
If all builds have passed: The CI system automatically lands the patch.
If the builds fail: The "autoland" flag is removed and the user is notified.

fineprint:

We need to define which users are allowed to do a auto-land?
Do we require code reviews for this feature?
Which GitHub account is used to land the patch? I suppose we cannot impersonate other users.

mtrofin commented 4 years ago

+1000 - I believe this would be a nice productivity booster! Having a commit queue would help avoid needing to investigate (even if minimally) what is often unrelated failures, and raise authors' confidence in their submission.

I'd add to the fineprint: "which bots are part of the auto-land group" - some bots may still need to run asynchronously (wrt submissions), because their execution takes too much time, or because they are a limited resource.

joker-eph commented 4 years ago

That would be great feature! Something that is really a pre-requisite for me to use a system is the robustness: right now pre-merge testing is almost constantly failing for an unrelated reason to the patch. This is "OK" as we can manually ignore (for example) an LLDB test while approving/landing an MLIR patch, but this would block an automated system.