search

google / llvm-premerge-checks

CI system for premerge-testing in LLVM project
Apache License 2.0
41 stars 37 forks source link

Issue with build for D80995 (267852) #194

Open labath opened 4 years ago

labath commented 4 years ago

Checks for a lot of lldb patches are failing due to clang-tidy not being able to find lldb header files. (I'm not sure it its "a lot" or "all" -- at this point I've gotten used to ignoring them.) This is confusing a lot of casual contributors.

It sounds like the problem is that the build that runs the clang-tidy checks does not have lldb enabled. See e.g. https://results.llvm-merge-guard.org/amd64_debian_testing_clang-1666/summary.html

DavidSpickett commented 3 years ago

Looking at a recent build of mine: https://buildkite.com/llvm-project/premerge-checks/builds/36608#f8a327b2-2845-41b7-85bf-6705e27d86b0

It sees that lldb was modified but then disables it due to test failures on Linux:


INFO    Projects directly modified by this patch:
--
  | lldb
  | INFO    modified projects: {'lldb'}
  | INFO    added set() projects as they are affected
  | INFO    projects with dependencies: {'lldb', 'clang', 'llvm'}
  | INFO    excluded for linux: {'libcxx', 'debuginfo-tests', 'lldb', 'libcxxabi'}
  | INFO    excluded for windows: {'polly', 'compiler-rt', 'libcxx', 'debuginfo-tests', 'libcxxabi', 'flang', 'lldb', 'libunwind', 'openmp', 'llgo'}
  | steps:

This exclude was added in https://github.com/google/llvm-premerge-checks/commit/07404db9a228d7eaf400c7a9eae9101494645143.

It's also disabled for Windows but that doesn't run clang-tidy.

The test failures don't immediately ring a bell for me but confirming whether they still fail would be the way forward I think.