search

google / llvm-premerge-checks

CI system for premerge-testing in LLVM project
Apache License 2.0
40 stars 37 forks source link

timeouts are reported as success #447

Open metaflow opened 1 year ago

metaflow commented 1 year ago

reported by @AaronBallman: https://discourse.llvm.org/t/pre-merge-checks-updates-may-2023/70589 build timed out yet buildkite acts as if it's OK. cc @movsic : I believe you have also experinced that

metaflow commented 1 year ago

initial hypothesis is the we just set such flags on build

metaflow commented 1 year ago

Job exceeded its execution timeout limit and was automatically stopped. Exit code 0 nope, looks like job exits with 0

metaflow commented 1 year ago

from the documentation: https://buildkite.com/docs/pipelines/command-step#timeout_in_minutes "Jobs that time out with an exit status of 0 are marked as "passed"." So it's a feature.

Asked a question on forum https://forum.buildkite.community/t/set-a-fail-status-to-a-timed-out-job/2916