search

google / lmctfy

lmctfy is the open source version of Google’s container stack, which provides Linux application containers.
Other
3.41k stars 237 forks source link

Duplicate SplitStringUsing etc. #25

Open huahang opened 10 years ago

huahang commented 10 years ago

The following 2 functions exist in both lmctfy/strings/strutil.cc and lmctfy/strings/split.cc

SplitStringUsing(std::string const&, char const, std::vector<std::string, std::allocator >)'

SplitStringAllowEmpty(std::string const&, char const, std::vector<std::string, std::allocator >)

huahang commented 10 years ago

maybe using namespace to guard these functions?

vmarmol commented 10 years ago

It looks like the ones in split.cc are in the strings namespace whereas the ones in strutil are at root. I think strutil should export the ones in split.cc instead, but that will probably require changes in some clients of strutil.