Skip Network Mounts - Githubissues

google / log4jscanner

A log4j vulnerability filesystem scanner and Go package for analyzing JAR files.

Apache License 2.0

1.56k stars 121 forks source link

Closed nikaiw closed 2 years ago

nikaiw commented 2 years ago

Add a flag to skip network mounts. Useful as servers may have huge remote mounts.

ericchiang commented 2 years ago

Thanks for the PR!

Happy to discuss this behavior, but I can't review the change without the CLA check. Please see https://github.com/google/log4jscanner/pull/39/checks?check_run_id=4720501806 for details

nikaiw commented 2 years ago

Thanks! I just added my CLA, it should be fine now (hopefully)

nikaiw commented 2 years ago

agreed, we can reverse the condition and change the name of the argument/variable

ericchiang commented 2 years ago

lgtm. please squash your commits and I'll merge