search

google / lyra

A Very Low-Bitrate Codec for Speech Compression
Apache License 2.0
3.84k stars 355 forks source link

Windows builds are a disaster #151

Open jhughes2112 opened 2 months ago

jhughes2112 commented 2 months ago

I've done this before a year ago, figured out the magic incantation to get Windows builds working. I'm trying to do it again (lost access to that wiki page), and I'm struggling, again. Bazel is a garbage system. I'm having to hack the python_configure.bzl to get it to recognize that Python.exe is actually an executable. PLEASE somebody actually start with a fresh Windows VM and outline the proper steps. So frustrating.

p0358 commented 2 months ago

It's from a fork, but maybe you'd have some luck with this: https://github.com/TFORevive/vaudio_lyra?tab=readme-ov-file#compile-on-windows

(and yes Bazel is pain, but I think Lyra might also be needing some older version or something)

jhughes2112 commented 2 months ago

Thanks much for the link, that'll help. I've gotten pretty far using Git Bash as the environment, MSYS was not doing the right thing for me. Running in a Windows cmd shell absolutely did not work. Newest versions of Bazel have very-breaking changes, and it seems pytorch depends on a newer version of Bazel than 5.0.0 that was originally used for Lyra. It's great tech, but the build process is garbage. There are some good things in that repo you mentioned. I'll post an update here for posterity once I get things working.

jhughes2112 commented 2 months ago

Leaving this here for future Windows devs. Lyra is very sensitive to Bazel versions. 5.0.0 did not work, but 5.3.2 does, 7.3.1 does not. Build systems are supposed to be agnostic to what they build. Sigh. Seems to me Bazel is increasing fragility of codebases, but hey, nobody asked my opinion. ;-)