google / lyra

A Very Low-Bitrate Codec for Speech Compression
Apache License 2.0
3.82k stars 354 forks source link

Building with CMake #50

Open KOLANICH opened 3 years ago

KOLANICH commented 3 years ago

It would be nice if all the components of the software that is not already present in the distro on user's mavhine be buildable with CMake, and ones that are presente just linked.

aluebs commented 3 years ago

Thank you for the request. Do you mean to use cmake instead of bazel?

KOLANICH commented 3 years ago

I mean exactly this. I am not a big fan of bazel (after my poor experience with it a few years ago when I tried to build TensorFlow with it). I cannot exclude that either I don't understand bazel enough, or that it may be misconfigured, but the 4 things that I currently perceive in bazel as the worst are

In other words, Bazel was created the way assumming that its users are big rich enterprises that can afford itself to waste resources, like Google is, and ignoring needs of everyone else, especially the needs of just users of distros who just want to build a bleeding edge version of the software from source as faster and as cheaper as possible, generate the package that reuses already installed deps as mjch as possible and install it into the system and publish it to allow other people to install it.

aluebs commented 3 years ago

Thank you for the detailed explanation. Those are all great points. Unfortunately I don't see us moving away from bazel any time soon, since it simplifies quite a bit our workflows. And maintaining a second build system independently seems like a lot of work and bug-prone. Do you know if there is a good way to translate bazel files into CMake?

KOLANICH commented 3 years ago

I have just googled a little and found these 2 projects:

I have used neither of them, but feel like I may need to give them a try somewhen for PlaidML - a machine learning library using OpenCL, so suitable for AMDs.

I can say something though about both of them. None of them has good enough source code, both look like they were made in haste with a lot of dirty shortcuts to spare the devs from writing a few lines of code, and both of them look a bit abandoned.

aluebs commented 3 years ago

If you end up trying any of them on Lyra, I'd love to hear about your experience.

xnorpx commented 3 years ago

dependencies is probably gonna be the painful part.