Closed reekystive closed 2 years ago
Thank you for doing this :)
Commit cac8b94 in this PR also added artifacts upload job for:
android-bin
android-app
linux-amd64
macos-amd64
I've refactored the actions to reduce duplication, please let me know if there are other issues and I'll try to fix it.
@aluebs or @mchinen, any chance one of you could review (or merge) this PR?
Sorry for overlooking this for so long. Will merge shortly.
Hi @reekystive, after merging looks like this is failing due to the ANDROID_NDK_HOME path https://github.com/google/lyra/runs/8100486980?check_suite_focus=true#step:1:7. Do you have an idea of how to resolve?
It looks like the latest image doesn't have this version of NDK pre-installed.
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#android
Let me try to update the NDK version used for building, or download an older version during CI.
Thanks @reekystive.
This fixes #76.
In the ubuntu-latest and macos-latest virtual environments, the default Bazel version is 5.0.0, which requires build-tools 30.0.0 or newer version to work properly. Lyra is currently using build-tools 29.0.3, which will cause Lyra failed to build with the default Bazel in GitHub Actions virtual environments.
This change will build Lyra with:
Bazel 5.0.0
build-tools 30.0.3
platforms android-30
ndk 21.4.7075529
(unchanged)Built successfully on hosts:
Ubuntu 20.04 (amd64)
linux-bin ✅
android-bin ✅
android-app ✅
macOS 11 (Intel)
macos-bin ✅
android-bin ❌
android-app ❌
macOS 12.2 (Apple Silicon)
macos-bin ✅
android-bin ❌
android-app ❌
I also added actions to build on more platforms:
android-bin
android-app
linux-amd64
macos-amd64
GitHub Actions also uploads artifacts for download nightly builds now.