google / lyra

A Very Low-Bitrate Codec for Speech Compression
Apache License 2.0
3.84k stars 355 forks source link

Build Lyra with Bazel 5.0.0 #78

Closed reekystive closed 2 years ago

reekystive commented 2 years ago

This fixes #76.

In the ubuntu-latest and macos-latest virtual environments, the default Bazel version is 5.0.0, which requires build-tools 30.0.0 or newer version to work properly. Lyra is currently using build-tools 29.0.3, which will cause Lyra failed to build with the default Bazel in GitHub Actions virtual environments.

This change will build Lyra with:

Built successfully on hosts:

I also added actions to build on more platforms:

GitHub Actions also uploads artifacts for download nightly builds now.

aluebs commented 2 years ago

Thank you for doing this :)

reekystive commented 2 years ago

Commit cac8b94 in this PR also added artifacts upload job for:

reekystive commented 2 years ago

I've refactored the actions to reduce duplication, please let me know if there are other issues and I'll try to fix it.

EwoutH commented 2 years ago

@aluebs or @mchinen, any chance one of you could review (or merge) this PR?

mchinen commented 2 years ago

Sorry for overlooking this for so long. Will merge shortly.

mchinen commented 2 years ago

Hi @reekystive, after merging looks like this is failing due to the ANDROID_NDK_HOME path https://github.com/google/lyra/runs/8100486980?check_suite_focus=true#step:1:7. Do you have an idea of how to resolve?

reekystive commented 2 years ago

It looks like the latest image doesn't have this version of NDK pre-installed.

https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#android

Let me try to update the NDK version used for building, or download an older version during CI.

mchinen commented 2 years ago

Thanks @reekystive.