search

google / lyra

A Very Low-Bitrate Codec for Speech Compression
Apache License 2.0
3.82k stars 354 forks source link

Update to NDK r25b LTS #93

Open EwoutH opened 2 years ago

EwoutH commented 2 years ago

The Android NDK used currently is a bit outdated, being the r21 LTS version. A new LTS version, r25, has been released, and contains a updated compiler and include updated Android APIs.

For CI, GitHub Actions has the NDK 25 available on its images.

It's latest exact version is 25.1.8937393.

mchinen commented 2 years ago

I can't tell if bazel support exists yet (there were some issues raised on the bazel githubs 1, 2, I see you on some threads too).

I see the new rules_android_ndk github repo exists and claims NDK 25b support, so we might try that.

EwoutH commented 2 years ago

Yes, I forgot to mention that. See https://github.com/bazelbuild/bazel/issues/12889#issuecomment-1233565322

mchinen commented 1 year ago

Would you be interested in sending us a PR for this @EwoutH ?

EwoutH commented 1 year ago

Sorry, I don't think I have the capacity to do that in the near feature, unfortunately.

cpsauer commented 1 year ago

Happened to see this via backlink. Can confirm that the new ndk rules work well as a drop in replacement allowing use of NDK r25, additionally solving a bunch of issues with the old implementation. That said, they don't support building on Windows just yet.