google / macops

Utilities, tools, and scripts for managing and tracking a fleet of Macintoshes in a corporate environment
Apache License 2.0
819 stars 86 forks source link

Fix PBDERDecoder #43

Closed jflinter closed 9 years ago

jflinter commented 9 years ago

I've been having issues with PBDERDecoder failing to properly parse the distinguishedNames of an NSURLProtectionSpace, and instead mistakenly returning nil. After searching around, I believe PBDERDecoder was copied from SNTDERDecoder in https://github.com/google/santa/. I'm not having any issues with that code, however. There are a few subtle differences in those files that I believe are causing the parser failures. This PR simply copies over the code from SNTDERDecoder.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jflinter commented 9 years ago

As the source in this PR is not of my original authorship, I'd prefer not to sign the CLA. As the CLA suggests to make explicit, this code was submitted on behalf of a third-party: Google. Thanks!

russellhancox commented 9 years ago

Thank you for your PR. If you have time, could you delete the trailing whitespace on otherwise empty lines? I suspect Xcode added it. If you don't let us know and I'll fix it up after merging.

jflinter commented 9 years ago

Sure, done. Thanks @russellhancox!

russellhancox commented 9 years ago

LGTM

jflinter commented 9 years ago

\o/

On Fri, Aug 28, 2015 at 3:46 PM, Russell Hancox notifications@github.com wrote:

Merged #43 https://github.com/google/macops/pull/43.

— Reply to this email directly or view it on GitHub https://github.com/google/macops/pull/43#event-395415968.