Closed jflinter closed 9 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
As the source in this PR is not of my original authorship, I'd prefer not to sign the CLA. As the CLA suggests to make explicit, this code was submitted on behalf of a third-party: Google. Thanks!
Thank you for your PR. If you have time, could you delete the trailing whitespace on otherwise empty lines? I suspect Xcode added it. If you don't let us know and I'll fix it up after merging.
Sure, done. Thanks @russellhancox!
LGTM
\o/
On Fri, Aug 28, 2015 at 3:46 PM, Russell Hancox notifications@github.com wrote:
Merged #43 https://github.com/google/macops/pull/43.
— Reply to this email directly or view it on GitHub https://github.com/google/macops/pull/43#event-395415968.
I've been having issues with PBDERDecoder failing to properly parse the
distinguishedNames
of anNSURLProtectionSpace
, and instead mistakenly returningnil
. After searching around, I believe PBDERDecoder was copied fromSNTDERDecoder
in https://github.com/google/santa/. I'm not having any issues with that code, however. There are a few subtle differences in those files that I believe are causing the parser failures. This PR simply copies over the code fromSNTDERDecoder
.