google / madi

Multivariate Anomaly Detection with Interpretability (MADI) published in ICML 2020
https://proceedings.mlr.press/v119/sipple20a.html
Apache License 2.0
75 stars 24 forks source link

Improve build system #1

Closed pganssle-google closed 4 years ago

pganssle-google commented 4 years ago

The biggest thing this fixes is that right now the package lives in the repo root, but it is supposed to live in a subdirectory of the repo root. There were other problems with the way this was packaged as well, but this migrates over to using the src/ layout, adds the necessary __init__.py files, and makes this a PEP 517 project (removing setup.py in favor of setup.cfg).

I also noticed one place where the migration from absltest to pytest was incomplete — not sure how that made it through without the tests failing on the Google side.

Things that I think still need to be done:

  1. Enable CI of some sort to build and test this package.
  2. Add a tox environment for running the builds.

I can help with those later, but this should fix the immediate problems.