search

google / mail-importer

Mail Importer for Gmail will upload the contents of a Thunderbird mail archive to Gmail and do its best to preserve the read state, flagged state, and folders of the messages.
Apache License 2.0
253 stars 91 forks source link

Update mail-importer to work again #15

Closed xylo04 closed 1 year ago

xylo04 commented 1 year ago

Update Java platform, dependencies and tests. Use google_java_format.

xylo04 commented 1 year ago

Would you be willing to split this into two changes? The first would be all of the formatting changes (along with a change to CONTRIBUTING.md) and the second would be the substantive changes that actually make it work.

Sure, I can do that. Would you prefer to see those as two separate PRs or just two commits in one PR?

xylo04 commented 1 year ago

Thank you for updating this to use the loopback address since the OOB method was deprecated.

Note that the way I'm doing this at the moment, I'm not actually starting a web server to capture that callback; I'm just letting the browser fail then copying the token out of the URL.

iflan commented 1 year ago

Thank you. This is excellent. If you want to improve it, adding a little bit about having the browser redirect fail and copying the token from the URL might be useful.