search

google / marl

A hybrid thread / fiber task scheduler written in C++ 11
Apache License 2.0
1.89k stars 193 forks source link

Add MSVC check to the __nop call #234

Closed HyHy100 closed 1 year ago

HyHy100 commented 1 year ago

Marl fails to build on MinGW-w64 on Windows because __nop is a MSC instruction.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ben-clayton commented 1 year ago

Unfortunately we cannot accept changes without signing the CLA. Closing.