search

google / martian

Martian is a library for building custom HTTP/S proxies
Apache License 2.0
2.01k stars 247 forks source link

go.mod cleanup #344

Open nohajc opened 2 years ago

nohajc commented 2 years ago

Out-of-sync go.mod with a reference to unused old version of protoc-gen-go-grpc causes a false positive finding in OWASP dependency-check.

Running go mod tidy fixes the issue. Also fixes #327.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

CarstenLeue commented 9 months ago

Hi @nohajc looks like the PR is not merged because of https://github.com/google/martian/pull/344#issuecomment-1195738697

Would you be able to comply to these requirements?

nohajc commented 9 months ago

Hello, this PR seems to be outdated as there are merge conflicts. The only thing I did was to run go mod tidy and submitted the result.

If this library is maintained again, I think it will be easier for you to close this PR and repeat the same steps on master (in case it's still needed).