search

google / marzipano

A 360° media viewer for the modern web.
http://www.marzipano.net
Apache License 2.0
2k stars 997 forks source link

Export button unresponsive if template files fail to be downloaded #93

Closed andrewminchew closed 7 years ago

andrewminchew commented 7 years ago

I load in a few images, or even just a single image (equirectangular, shot on Ricoh Theta S), wait for it to process (it renders fine in the browser), click the export button, and nothing happens (no error dialogs or anything).

Google Chrome MacOS Sierra 10.12.5 Mid 2010 iMac 21.5inch 3.2 GHz Intel Core i3 16GB Ram ATI Radeon HD 5670 512 MB

I've tried on another machine (similar setup, might have been 2011 21.5inch 16gb ram), and get the same response. Other machines (Late 2015 iMac w Sierra, Early 2015 MBP w El Capitan) have no problem (using same images).

Any ideas / suggestions?

andrewminchew commented 7 years ago

having the same issue on a windows 7 system, details attached... system

tjgq commented 7 years ago

Do any error messages appear in the developer console (Ctrl-Shift-J)?

andrewminchew commented 7 years ago

Is this what you needed to see?

Andrew Minchew

On Mon, Jul 10, 2017 at 7:54 AM, Tiago Quelhas notifications@github.com wrote:

Do any error messages appear in the developer console (Ctrl-Shift-J)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/marzipano/issues/93#issuecomment-314096683, or mute the thread https://github.com/notifications/unsubscribe-auth/AY9ZYD0qdc2bQZcGISD8rAaMTX5Dg8Ejks5sMh7-gaJpZM4OQPnv .

tjgq commented 7 years ago

I don't see anything, sorry. Did you forget an attachment?

andrewminchew commented 7 years ago

I included the attachments, I guess they didn't go through? Here's a dropbox folder with two screenshots in it.

https://www.dropbox.com/sh/0tj3divwozla6ch/AADAZWjbgIIF4IkFiIyCbqPSa?dl=0

Andrew Minchew

On Fri, Jul 14, 2017 at 12:41 PM, Tiago Quelhas notifications@github.com wrote:

I don't see anything, sorry. Did you forget an attachment?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/marzipano/issues/93#issuecomment-315421262, or mute the thread https://github.com/notifications/unsubscribe-auth/AY9ZYCW-HLB2mQDwDHHFSMzWaJu3HzMlks5sN6hhgaJpZM4OQPnv .

tjgq commented 7 years ago

My guess is that an overly-aggressive antivirus or content filtering system is preventing the page from downloading an .exe file. This is a small, self-contained webserver executable that we include in generated tours.

andrewminchew commented 7 years ago

A Mac would ignore the .exe file altogether though right? On Fri, Jul 14, 2017 at 5:48 PM Tiago Quelhas notifications@github.com wrote:

My guess is that an overly-aggressive antivirus or content filtering system is preventing the page from downloading an .exe file. This is a small, self-contained webserver executable that we include in generated tours.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/marzipano/issues/93#issuecomment-315485491, or mute the thread https://github.com/notifications/unsubscribe-auth/AY9ZYPqJrXhCBCevKgmoG4YuR2jmVpCcks5sN_BKgaJpZM4OQPnv .

tjgq commented 7 years ago

No, the tool downloads both executables (Windows and Mac) and adds them to the zip file regardless of the platform it is running on.

andrewminchew commented 7 years ago

Ah, so it's rejecting the zip file because it sees the .exe inside? On Fri, Jul 14, 2017 at 8:05 PM Tiago Quelhas notifications@github.com wrote:

No, the tool downloads both executables (Windows and Mac) and adds them to the zip file regardless of the platform it is running on.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/marzipano/issues/93#issuecomment-315498941, or mute the thread https://github.com/notifications/unsubscribe-auth/AY9ZYJD5qaqGCziG3guL7Ev7BCscTytpks5sOBBJgaJpZM4OQPnv .

tjgq commented 7 years ago

No, the zip file is never created.

The tool downloads files to be included in the zip file (the .exe is one of them), and then generates the zip file locally when you click the Export button.

Because the .exe file fails to be retrieved (this is the first console error), the code that generates the zip file crashes (this is the second console error, "Template files not loaded").

We should probably pop up an alert dialog if some of the files fail to be downloaded, since export is guaranteed to fail when that happens.

andrewminchew commented 7 years ago

Got it! I'll tell IT to ease up on us :) thanks! And great work! I'd love to be able to pay for hosting and being able to come back later and edit through the same interface! Keep up the good work! On Fri, Jul 14, 2017 at 8:15 PM Tiago Quelhas notifications@github.com wrote:

No, the zip file is never created.

The tool downloads files to be included in the zip file (the .exe is one of them), and then generates the zip file locally when you click the Export button.

Because the .exe file fails to be retrieved (this is the first console error), the code that generates the zip file crashes (this is the second console error, "Template files not loaded").

We should probably pop up an alert dialog if some of the files fail to be downloaded, since export is guaranteed to fail when that happens.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/marzipano/issues/93#issuecomment-315499600, or mute the thread https://github.com/notifications/unsubscribe-auth/AY9ZYAmz8LhqwO-spCbkBrSH6ljvcpjsks5sOBKbgaJpZM4OQPnv .

tjgq commented 7 years ago

Due to the number of issues it was causing, we decided to omit the .exe file from generated tours. This should make export work again.