google / material-design-icons

Material Design icons by Google (Material Symbols)
http://google.github.io/material-design-icons/
Apache License 2.0
50.47k stars 9.56k forks source link

icons named "tag_faces" is messed. #1205

Open darkRaspberry opened 3 years ago

darkRaspberry commented 3 years ago

What the issue

The icons named "tag_faces" is messed up style filled, rounded is incorrect. The filled one is empty and and rounded one is filled.

Icon named - tag_faces style with error - filled, rounded The filled one is empty and and rounded one is filled.

Screenshot from 2021-08-05 20-35-14 Screenshot from 2021-08-05 20-35-03

Naaru-01 commented 3 years ago

Hello there, I would like to work on this issue.

image image

This should look like this. Correct?

But I'm not able to see the guidelines how to contribute .

Please ping me back as soon as possible.

darkRaspberry commented 3 years ago

@Naaru-01 I'm sure about "filled" one. sharp, outlined and rounded. look like very very very similer.

darkRaspberry commented 3 years ago

I think the rounded one should have little smooth mouth edge.

Naaru-01 commented 3 years ago

Yeah, I see it .

You can assign me this .

Could you please guide be bit about guidelines to contribute and where the codebase is .

darkRaspberry commented 3 years ago

I don't think https://github.com/google/material-design-icons/tree/master/font here try this. These are point values i think and you need to change that value.

Also- I don't think the contributers are active. it may take time to merge

Naaru-01 commented 3 years ago

OK OK

Naaru-01 commented 3 years ago

Please help me, I am confused and I am not getting this right.

Still I don't find the actual code.

I found the codepoints but they are have same value . What after that .

Exactly where to contribute is still the issue.

darkRaspberry commented 3 years ago

Acording to my understanding. only thing which u can edit it codepoints. The value points to some svg file. you can swap the value of codepoint between outline and filled

tphinney commented 2 years ago

@darkRaspberry I am sorry to tell you, that is not how the icons or the icon fonts work. Changing this file will not accomplish what you want. :(

The codepoint file is informative: it tells people, for a given icon/glyph name, what codepoint it should have. It does not drive or change anything; upstream, a different codepoint file in a different format using decimal instead of hex codepoints does that, for the Material Icons fonts only.