search

google / material-design-icons

Material Design icons by Google (Material Symbols)
http://google.github.io/material-design-icons/
Apache License 2.0
50.13k stars 9.6k forks source link

Outlined icon for label_important is incorrect #1440

Open kerim1510 opened 1 year ago

kerim1510 commented 1 year ago

The outlined icon for label_important is filled instead of outlined

tphinney commented 1 year ago

Note: this is specific to the old Material Icons — everything is fine in Material Symbols.

In Material Icons, in the Outline style, “label_important” is filled. In the Filled, Rounded, Sharp and Two Tone styles, there are two separate icons: “label_important” and “label_important_outline” and the first is filled and the second is not.

tphinney commented 1 year ago

I can imagine two different options for fixing this in Material Icons: 1) Copy “label_important_outline” from Filled set to the Outlined set, so the Outlined set has both a filled and an outlined version just like Filled 2) Change the existing “label_important” in the Outlined set to be a copy of “label_important_outlined” from the Filled set; the Outlined set still has just one version, but it is outlined

Also, all the Material Icons versions of this icon are sized a bit differently than the Material Symbols versions. Just noting the difference.

kerim1510 commented 1 year ago

I can imagine two different options for fixing this in Material Icons:

  1. Copy “label_important_outline” from Filled set to the Outlined set, so the Outlined set has both a filled and an outlined version just like Filled
  2. Change the existing “label_important” in the Outlined set to be a copy of “label_important_outlined” from the Filled set; the Outlined set still has just one version, but it is outlined

Also, all the Material Icons versions of this icon are sized a bit differently than the Material Symbols versions. Just noting the difference.

I would suggest option 1. since I see no reason for a filled icon in a Outlined set.