google / material-design-icons

Material Design icons by Google (Material Symbols)
http://google.github.io/material-design-icons/
Apache License 2.0
50.56k stars 9.57k forks source link

SVGs not updated to match TTF changes (/pause /battery_charging_60) #1531

Open alexstyl opened 1 year ago

alexstyl commented 1 year ago

The SVG version of Pause looks significantly different to the ttf version.

TTF SVG
image 74 Screenshot 2023-06-22 at 01 02 54

PS: Ignore the background. The ttf is loaded on a website. while the SVG is from this repo previewed on Intellij IDEA.

As you can see, the thickness and shape of the two icons are different.

On the left you see 'pause' from MaterialSymbolsRounded with FILL1 wght400 GRAD 0 opsz40.

On the right you see materialsymbolsrounded/pause_fill1_40px.svg.

I believe that the two should look alike. I double checked and it seems like the ttf is the meant respective version of the svg.

tphinney commented 1 year ago

@alexstyl Is the SVG perhaps from Material Icons instead of Material Symbols?

alexstyl commented 1 year ago

@tphinney I am using the SVGS from /symbols/web/. I am assuming those are the Symbols ones, aren't they?

The SVG displayed on the original post is this one. It seems quite thick compared to the font version even while using the Github preview:

image
Dionis-mgn commented 1 year ago

Another example is battery_charging_60 (and similar) icon. In repo all the versions of those icons are fillled: not filled and filled are the same icons.

fonts.google.com has it right though: unfilled and filled

tphinney commented 1 year ago

@alexstyl yes, those are the Symbols ones and should in theory be correct.

In this particular case, I remember well how the filled versions of the Pause icon were updated in the Symbols font earlier this year. It was an unusual case/decision (from a design perspective) and we discussed it in our internal repo WAY more than any sane person would expect. 😝

@Dionis-mgn Yes, /battery_charging_60 is another thing that was changed/enhanced at some point — even further back than /pause.

alexstyl commented 1 year ago

thanks for confirming @tphinney. are there any plans to update the svgs in the repo any time soon?

sabinebarrera commented 1 year ago

@alexstyl did you choose the right configuration for your SVG symbol?

When using a ttf symbol you must set your Text's font correctly:

Text(
   text = "\ue87d", // Favorite icon
   fontFamily = materialIconsRoundedFontFamily,
   fontSize = 24.sp,
   fontWeight = FontWeight.Light
)
alexstyl commented 1 year ago

@sabinebarrera I am aware of the configurations of the ttf. You can find the configurations I am using in the 1st post.

The bug discussed is about inconsistencies between the ttf and the svgs founds in this repository. It is not related to Jetpack Compose.