search

google / material-design-icons

Material Design icons by Google (Material Symbols)
http://google.github.io/material-design-icons/
Apache License 2.0
49.88k stars 9.65k forks source link

Web symbol for `star` doesn't have a non-fill version #1702

Closed joshjhall closed 5 days ago

joshjhall commented 1 month ago

Entirely possible I'm missing something, but it appears the web version of the star symbol SVG is incorrect. Both the fill and non-fill versions have the fill SVG. The iOS and Android versions appear correct, so possibly limited to how the web SVG was generated. I also haven't noticed the issue with any other symbols, so it might be quite limited in scope. Note, star_rate appears correct.

For example, for star @ style=rounded, weight=400, fill=off, grade=normal, optical size=24dp Expected CleanShot 2024-03-26 at 12 32 11@2x

File in symbols/web/star/materialsymbolsrounded/star_24px.svg shows CleanShot 2024-03-26 at 12 36 10@2x

joshjhall commented 1 month ago

The edit SVG also appears different than what's packaged in the font and such. Is the web SVG deprecated or out of date?

tphinney commented 1 month ago

Hmmm. I remember the default state for /star got changed a while back (as in, last year IIRC). Seems like maybe the SVG did not get regenerated.

/edit is also one that has been changed in the past year or so.

@EsoFromTheEast is this something you could address?

joshjhall commented 1 month ago

Found another one this morning, emergency. May help track down when the SVG stopped regenerating.

joshjhall commented 1 month ago

Thanks @tphinney and @EsoFromTheEast!

https://github.com/google/material-design-icons/issues/1531 might be the same issue. It appears the SVG for pause is still out of date compared with the font and Figma sources as well.

joshjhall commented 1 month ago

edit_document and star_half are also out of date

tphinney commented 2 weeks ago

This should at last be fixed now?

tphinney commented 5 days ago

I believe this is fixed. Let us know if not!