google / material-design-icons

Material Design icons by Google (Material Symbols)
http://google.github.io/material-design-icons/
Apache License 2.0
50.72k stars 9.59k forks source link

Failed to decode downloaded font + OTS parsing error (Windows 7 x64, Chrome 109) #1798

Open 777-0-777 opened 2 months ago

777-0-777 commented 2 months ago

Windows 7 x64, Chrome 109

Icons show raw texts!

Failed to decode downloaded font: https://fonts.gstatic.com/s/googlematerialicons/v142/Gw6kwdfw6UnXLJCcmafZyFRXb3BL9rvi0QZG3Q.woff2

OTS parsing error: Unable to instantiate font face from font data.

2 3 4 1

777-0-777 commented 2 months ago

The problem appeared approximately one week ago.

Please fix it.

777-0-777 commented 1 month ago

Such a problem has arisen before:

https://github.com/google/material-design-icons/issues/1220

777-0-777 commented 1 month ago

@garretrieger Can you fix this?

simone-desantis commented 1 month ago

It's worth mentioning that this issue seems not be there when using the latest build of win7

simone-desantis commented 1 month ago

Also: It is introduced in v142 , v141 works fine.

garretrieger commented 1 month ago

I'm not able to get this to reproduce locally for me, do you see the issue on this test page?

https://codepen.io/garretrieger/full/xxvRgOJ

Also what version of windows 7 are you on?

simone-desantis commented 1 month ago

I am reproducing it in one of the earliest win7 builds: 7600 Here you see a temporary workaround demo: https://github.com/simone-desantis/chrome-font-replacer Here is your rendering: Image

garretrieger commented 1 month ago

Thanks, since this is only failing on specific versions of windows 7 this seems like it's very likely the same issue as #1220. I'll check the font binaries between v141 and v142 and see if I can spot any changes in ordering of coverage data that would trigger the bug in #1220.

777-0-777 commented 1 month ago

I'm not able to get this to reproduce locally for me, do you see the issue on this test page?

https://codepen.io/garretrieger/full/xxvRgOJ

Also what version of windows 7 are you on?

@garretrieger

Image Windows 7 Professional Build 7601 Service Pack 1

Image

OrionisQul commented 1 month ago

Windows 10

сб, 12 окт. 2024 г., 20:58 777-0-777 @.***>:

I'm not able to get this to reproduce locally for me, do you see the issue on this test page?

https://codepen.io/garretrieger/full/xxvRgOJ

Also what version of windows 7 are you on?

@garretrieger https://github.com/garretrieger

Screenshot1.png (view on web) https://github.com/user-attachments/assets/331714c6-2a7a-4467-bfbf-2fe71462eeb6 Screenshot2.png (view on web) https://github.com/user-attachments/assets/893f50a8-2a05-4804-8542-70432590ee01

— Reply to this email directly, view it on GitHub https://github.com/google/material-design-icons/issues/1798#issuecomment-2408591941, or unsubscribe https://github.com/notifications/unsubscribe-auth/BK7HB4OEDOCVF6EESVN5RX3Z3E2J5AVCNFSM6AAAAABPA66ZYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGU4TCOJUGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

777-0-777 commented 1 month ago

@garretrieger

Is there any news?

garretrieger commented 1 month ago

Can you try this new test page and let me know which of the samples fails to load? https://garretrieger.github.io/font-debugging/index.html

simone-desantis commented 1 month ago

Home and logout base 142: Image

garretrieger commented 1 month ago

Thanks, this is very helpful! I've updated that page with some additional tests would you be able to check again?

simone-desantis commented 1 month ago

Absolutely: Image

garretrieger commented 1 month ago

Alright, I've narrowed down the problem to likely being in the CFF table encoding. I've got a temporary fix that I've deployed to our test API and if that looks like it works we can get the fix out for the prod font early next week.

Could you check this test page which includes the updated font from the test api?

https://codepen.io/garretrieger/full/JjgMXza

If the fix worked, then v143 should load without errors.

tomasdev commented 1 month ago

Home and logout base 142:

[offtopic]

@simone-desantis If you don't mind me asking... why are you on Windows 7 to which Microsoft stopped sending security updates in 2020?

simone-desantis commented 1 month ago

@garretrieger issue fixed Here the result: Image

simone-desantis commented 1 month ago

@tomasdev I am not :) I crossed this problem and helped to debug. It's strongly discouraged to use such setup. I am mentioning this as disclaimer in the temporary workaround I made available here: https://github.com/simone-desantis/chrome-google-font-replacer?tab=readme-ov-file#disclaimer-1

777-0-777 commented 1 month ago

Image Image Image Windows 7 Professional Build 7601 Service Pack 1

garretrieger commented 1 month ago

Ok great looks like the fix works. We'll get the process started of rolling this out to prod. Should land in production in a couple of days.

garretrieger commented 4 weeks ago

The fixed version is now on prod. You may need to clear your browser cache to get it.

simone-desantis commented 4 weeks ago

I confirm that the v143 is correctly renderd. Just FYI i.e. calendar still hasn't rolled out the v143. Is this in the hands of the google workspace team?

garretrieger commented 4 weeks ago

I'll check in on that and see if I can get it updated.

garretrieger commented 2 weeks ago

The fix should be out now for calendar.

simone-desantis commented 2 weeks ago

Yes it is, I guess that then this is done 👍