Checkbox Ripple position

google / material-design-lite

Material Design Components in HTML/CSS/JS

https://getmdl.io

Apache License 2.0

32.28k stars 5.04k forks source link

Checkbox Ripple position #1918

Open virtyaluk opened 8 years ago

virtyaluk commented 8 years ago

Seems like Checkbox Ripple container aligned 1px lower than it supposed to be. untitled-1 untitled-3

Next code compiles to 6px instead of 7px.

top: -(($checkbox-ripple-size - $checkbox-label-height) / 2);

Maybe, this section of _variables.scss should be corrected.

Garbee commented 8 years ago

Not sure on what the spec actually says to this. Marking appropriately and someone from the team can take a peek as they have time.

virtyaluk commented 8 years ago

@Garbee It's not a matter of specification. It's a matter of visual perception. It is obvious that the ripple container aligned 1px lower and it catches the eye.