search

google / mathfu

C++ math library developed primarily for games focused on simplicity and efficiency.
http://google.github.io/mathfu
Apache License 2.0
1.4k stars 188 forks source link

Added Equal and Not Equal operator overload in Vector #15

Closed herculesjr closed 8 years ago

herculesjr commented 8 years ago

I've added operator==() and operator!=() to Vector template

stewartmiles commented 8 years ago

Thanks for the pull request, I've added a few comments for potential improvements. Please let me know what you think.

herculesjr commented 8 years ago

I changed all the code that you commented. Please let me know if I need to change something else.

stewartmiles commented 8 years ago

Looks good, thanks.

herculesjr commented 8 years ago

Thanks for accepting this @stewartmiles, when will become available in the master branch?

stewartmiles commented 8 years ago

Going through the process of merging this internally now, should be at some point today.

On Thu, Jun 9, 2016 at 9:42 AM, Hercules Junior notifications@github.com wrote:

Thanks for accepting this @stewartmiles https://github.com/stewartmiles, when will become available in the master branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/mathfu/pull/15#issuecomment-224954175, or mute the thread https://github.com/notifications/unsubscribe/AFw1RFmeLK1IyOoR_GLFit0l23OKXEf_ks5qKEJdgaJpZM4IxYsT .

stewartmiles commented 8 years ago

Oh I just noticed the final commit wasn't squashed. I'll do it on this end which means I'll be rewriting the history of develop in a couple of hours so be aware your fork will end up with some conflict so you'll need to do a "git reset --hard" to the google/mathfu "develop" branch.

On Thu, Jun 9, 2016 at 9:44 AM, Stewart Miles smiles@google.com wrote:

Going through the process of merging this internally now, should be at some point today.

On Thu, Jun 9, 2016 at 9:42 AM, Hercules Junior notifications@github.com wrote:

Thanks for accepting this @stewartmiles https://github.com/stewartmiles, when will become available in the master branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/mathfu/pull/15#issuecomment-224954175, or mute the thread https://github.com/notifications/unsubscribe/AFw1RFmeLK1IyOoR_GLFit0l23OKXEf_ks5qKEJdgaJpZM4IxYsT .

stewartmiles commented 8 years ago

Integrated as https://github.com/google/mathfu/commit/ba829f86a10a126faf9283b901f62f3fc9bc5c35 into master