adding factoring support

google / mathsteps

Step by step math solutions for everyone

https://socratic.org

Apache License 2.0

2.12k stars 275 forks source link

adding factoring support #104

Closed aelnaiem closed 7 years ago

aelnaiem commented 7 years ago

Issue: https://github.com/socraticorg/mathsteps/issues/50

Adds support for factoring by:

difference of squares
perfect squares
sum product rule

Quadratic equation to be added in the future. The reason I didn't add it yet is because it requires simplification of only what will be in the brackets (without expansion), and I didn't want to make a decision on how that should happen.

evykassirer commented 7 years ago

I'm worried that 2x^2 + 2x -> 2x(x + 1) might still not work

evykassirer commented 7 years ago

still missing tests for factorSymbol with negate - I think there might be bugs there

evykassirer commented 7 years ago

added 6 comments, mostly just stuff you missed from the last code review

lemme know if there's anything I can do to make it easier for you to see and check off my comments to make sure you address them all (I know github doesn't really do a good job of making it easy)

evykassirer commented 7 years ago

👍