google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 275 forks source link

Prioritize simple fraction simplification #109

Open aelnaiem opened 7 years ago

aelnaiem commented 7 years ago

2 - 6/6 will convert 2 into a fraction and do the subtraction instead of simplifying 6/6 to 1. 2 - 12/6 will do the same.

This should be a simple check to see if any fractions can evenly divide out before we combine them.

evykassirer commented 7 years ago

I thought this logic already existed somewhere, so probably a bug in ordering of simplifications? I thought simplify arithmetic always went first and divided things first if they became integers

aelnaiem commented 7 years ago

Yea, I was surprised when I saw this happen. Could just be a bug