search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 275 forks source link

Refactor test to use TestUtil (ct'd from #99) #117

Closed nitin42 closed 7 years ago

nitin42 commented 7 years ago

addresses #42

evykassirer commented 7 years ago

@aelnaiem did travis not run on this because it was opened before you made that change?

nitin42 commented 7 years ago

Adding done() callback to some tests because they are taking too much of a time to run (exceeding 2000).

evykassirer commented 7 years ago

thanks so much for making these changes and for your patience with the review process!!

nitin42 commented 7 years ago

Well now I can work on the other issues 😄

evykassirer commented 7 years ago

yay :D

nitin42 commented 7 years ago

Something that could make reading the codebase a little easier !?

evykassirer commented 7 years ago

what kind of thing were you thinking? what makes it hard for you to read the codebase right now?

evykassirer commented 7 years ago

also did you still want to do that test coverage stuff?

nitin42 commented 7 years ago

Well its all clean and tidy. I am understanding the mathjs expression tree right now. I think it would help. Ya I am interested in writing the test coverage.

nitin42 commented 7 years ago

Also I wanted an example for the rearrangeable function ,....

nitin42 commented 7 years ago

./lib/checks/canRearrangeCoefficient.js

// Returns true if the expression is a multiplication between a constant
// and polynomial without a coefficient.

I didn't get this. Comment is obfuscated !

evykassirer commented 7 years ago

what do you mean by "rearrangeable function"?

for the second one - yeah that's a weird concept in general.

I should have added examples e.g. x*2 -> 2x, e.g. y^3*7 -> 7x^3 - would that help?

nitin42 commented 7 years ago

I get it now !