search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 275 forks source link

Missing tests #119

Closed nitin42 closed 7 years ago

nitin42 commented 7 years ago

addresses #58

Let me know about these ones. yet to write for EquationOperations.js

nitin42 commented 7 years ago

I think its ./lib/learn.js for failed checks !

evykassirer commented 7 years ago

oops, added a few more comments I forgot last time

thanks your patience - I think we can merge this very soon!

nitin42 commented 7 years ago

Ya sure. no hurries !!

nitin42 commented 7 years ago

Sorry... coz previously I added a file by mistake which was for my use only . Deleted in this commit !

evykassirer commented 7 years ago

just one more small change then I'm happy to merge this :D

evykassirer commented 7 years ago

thanks for doing this! :D

nitin42 commented 7 years ago

hahaha 😆

nitin42 commented 7 years ago

I need some more clarity on the collect and combine search ! R u online on Gitter right now ?

evykassirer commented 7 years ago

yup!