search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 275 forks source link

Build error #166

Closed nitin42 closed 7 years ago

nitin42 commented 7 years ago

If we minify the mathsteps lib using UglifyJs2 it gives build error because UglifyJs2 doesn't support ES6 (not totally sure). Considering the browser support for the ES6 build, we need to transpile ES6 to ES5 (using Babel or Buble). Tracked at mishoo/UglifyJS2#448

evykassirer commented 7 years ago

Oo good to know. I don't have much experience with node -> browser code, but I guess we need it for our demo. I'm feeling pretty sick today but ll take a look into this in the next couple days

Thanks for bringing it up :)

nitin42 commented 7 years ago

Can I look into this further ? Like adding browser support, providing UMD build and configuring Babel.

evykassirer commented 7 years ago

Yeah go for it! I just can't finalize anything rn cause I'm pretty busy but your research definitely helps :)

evykassirer commented 7 years ago

And I should be able to get back to ya next week if not earlier :)

nitin42 commented 7 years ago

I think we can add Babel to our project. Let me know what you think!

evykassirer commented 7 years ago

I'm pretty sure we'll be adding babel as part of the rule porting, but I don't want to change anything on master for the next couple weeks while that process is happening. @aliang8 can you confirm? I remember you being interested in adding Babel for something or other (I don't know that much about it)

nitin42 commented 7 years ago

@evykassirer Is there anything I can work on (I've two weeks before my college starts) ? Let me know!

aliang8 commented 7 years ago

Hey @nitin42! Thanks for asking! We should set up Babel to support ES6 syntax. Would you mind taking that on?

evykassirer commented 7 years ago

Setting up a polished demo would also be awesome

nitin42 commented 7 years ago

Ok! I am designing the site right now and will share the link soon. @aliang8 👍

nitin42 commented 7 years ago

Woaah!! Seems like we won't need to configure Babel for the project. We will provide production ready umd build which will be supported both on the web and node environment. I'll send a PR soon !