search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 274 forks source link

Add two more cases for cancelling terms #182

Closed aliang8 closed 7 years ago

aliang8 commented 7 years ago

https://cl.ly/1g310g3Q2M1P

evykassirer commented 7 years ago

lemme know when it's ready for review :)

evykassirer commented 7 years ago

can you make the description and comment name more descriptive? "stepper issue" is literally any issue in this codebase heh

I updated your other PR with an example of the level of detail I'm thinkin

ldworkin commented 7 years ago

Add some tests, at least one for each new case? :)

ldworkin commented 7 years ago

I think this one's ready for your review @evykassirer !

aliang8 commented 7 years ago

Fix the comments.

evykassirer commented 7 years ago

3 things left to do then I can accept this for you! and 🚢

evykassirer commented 7 years ago

woops sorry haha

also I updated the name of the PR to explain what's being fixed a bit more specifically

evykassirer commented 7 years ago

ONE more thing then squash and merge

ldworkin commented 7 years ago

Sorry @evykassirer I keep forgetting to squash! Not in the habit yet 😬

evykassirer commented 7 years ago

no worries! I actually updated the settings so it's the only option, which I should have just done before :)