google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 275 forks source link

Simplify roots of any degree (fixes cube root bug) #183

Closed aliang8 closed 7 years ago

aliang8 commented 7 years ago

Cube root grouping terms under the radicand is incorrect. In the image below, note there are groups of 2 2's instead of groups of 3 since it is a cube root.

https://cl.ly/0u0q3V0r3q2n

evykassirer commented 7 years ago

the image was really helpful for knowing what's going on here! can you also give a little description? it wasn't super clear to me just from the pic

evykassirer commented 7 years ago

also (this is a Socratic convention that I also use at Joyable!) when you're making branches, preface them with your initials so we know it's a branch you were working on

e.g. al_cube_root

aliang8 commented 7 years ago

Cube root grouping terms under the radicand is incorrect. In the case of the image, there are groups of 2 2's instead of groups of 3 since it is a cube root.

aliang8 commented 7 years ago

Made the request changes. :D Let me know if there's anything else.

evykassirer commented 7 years ago

@ldworkin reminder please squash and merge in da future! then we don't have things like trailing spaces whut in master 🤣

evykassirer commented 7 years ago

once you do it once, it should keep that as the default then on