search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 274 forks source link

multiply fractions with parenthesis #185

Closed ldworkin closed 7 years ago

ldworkin commented 7 years ago

https://github.com/socraticorg/mathsteps/issues/137

ldworkin commented 7 years ago

I know in the issue you suggested that one potential fix was to modify removeUnnecessaryParentheses, but that made me nervous ...

aliang8 commented 7 years ago

This looks good to me.

evykassirer commented 7 years ago

looks good!! I think you can add the unary minus back in :)

evykassirer commented 7 years ago

You can clean up the test structure if you want, and I think a more descriptive name would be good - but yeah looks awesome! Messy stuff and weird things to work with, but you handled it all pretty cleanly 🎉