search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 274 forks source link

Expand exponent #194

Closed aliang8 closed 7 years ago

aliang8 commented 7 years ago

Fix the issue where (nthRoot(x,2))^2 does not evaluate to x (returns no steps).

ldworkin commented 7 years ago

Really pleased with this, well done @aliang8 ! Great comments and test cases. And code was very readable. Just left a few things to address.

ldworkin commented 7 years ago

@evykassirer once @aliang8 addresses my confusion above, can this be approved/merged?

evykassirer commented 7 years ago

sorry was falling behind :( didn't get time to review this today. Figured I'd wait for your review to get resolved. If it's urgent feel free to merge, otherwise I might be able to get to it tomorrow before I head to work or latest after work