search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 274 forks source link

Operator nodes should have > 1 arguments #198

Open ldworkin opened 7 years ago

ldworkin commented 7 years ago

See the discussion here: https://github.com/socraticorg/mathsteps/pull/190#discussion_r127018474

Essentially, if we check for args.length > 1 in the isOperator check, some tests involving nthRoots will fail. Why is that? All operator nodes should have at least 2 arguments.

evykassirer commented 7 years ago

thanks for opening this :D