google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 274 forks source link

distribute fractions normally #207

Closed ldworkin closed 7 years ago

ldworkin commented 7 years ago

Not sure why we had special logic for fractions before.

Previously: 4(5/4 + x) => (5 4)/4 + x 4

Now: 4(5/4 + x) => 4 (5/4) + 4 x

evykassirer commented 7 years ago

omg lol I think I know why this was the case - remember how the cancelling didn't work that well before? I think this was to get around that (not totally sure but that's my guess for now)

ldworkin commented 7 years ago

Make sense re: cancelling ... I think?! Though the change I made to the cancelling code was to make it work for parens, and there are no parens here ... anyway hopefully this doesn't break anything terribly! I tested a bunch and Gen will do so more.