#163 - Better sum-product factoring steps

google / mathsteps

Step by step math solutions for everyone

https://socratic.org

Apache License 2.0

2.12k stars 274 forks source link

#163 - Better sum-product factoring steps #210

Closed alainakafkes closed 7 years ago

alainakafkes commented 7 years ago

Following the conventions used in addConstantFractions.js, I broke down factorQuadratic into 3 substeps:

Break apart the middle term into two terms using our factor pair (p and q): ax^2 + bx + c --> ax^2 + px + qx + c
Factor both groups separately: first group as [ux(rx + s)] and second group as [v(rx + s)]
Finish factoring by combining the factored terms through grouping: (ux + v)(rx + s)

Please let me know if there are any problems and how I can fix them! 😊

aelnaiem commented 7 years ago

Dope!

alainakafkes commented 7 years ago

Okay @evykassirer I think I addressed all of your requested changes! 🎉 Please let me know if I should make any more.

evykassirer commented 7 years ago

changes look great! just one unaddressed comment I commented on

also

I'd love to see some new tests showing how this works - there are some tests already that test substeps (the fractions code you were basing this off of probably has some!) so you can do some stuff similar to that!