#162 bugfix - Large negtive number rounding

starside commented 7 years ago

Fixed bug #162, and added tests to check that large negative numbers do not round. Also commented out broken test related to test #162.

evykassirer commented 7 years ago

🎉 yay! thanks for fixing this

just two small comments then let's merge this!! :D

starside commented 7 years ago

Thanks for the comments, I have made the changes. Assuming this passes, should I pick some open issue and give it a go?

evykassirer commented 7 years ago

yup! feel free to work on something else open. I'm hoping to move the focus to porting over to math-rules and math-parser soon, so feel free to check those out at https://github.com/semantic-math

If you wanna do some more stuff in the meantime:

198 would be goo to look into
146 would be really helpful and will continue to stay in the codebase despite changing to a new parse tree (not sure what else will stay vs change)
109 is a neat teaching related one to look into (we don't only want to get the right answer, we want to get there in a way that makes sense!)

feel free to check out some other open issues, those were just some that stood out to me

thanks for spending your time on this project! I really appreciate it. If you have any questions or need help with anything, just let me know :)

google / mathsteps

#162 bugfix - Large negtive number rounding #216

198 would be goo to look into

146 would be really helpful and will continue to stay in the codebase despite changing to a new parse tree (not sure what else will stay vs change)

109 is a neat teaching related one to look into (we don't only want to get the right answer, we want to get there in a way that makes sense!)