search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.11k stars 276 forks source link

Missing parentheses when multiplying with a negative number #240

Open Stumblefeet opened 5 years ago

Stumblefeet commented 5 years ago

A well-formed formula does not allow for a multiplication sign to be followed by a minus sign.

I recently tried 2-5(3-6) and got 2-5-3

evykassirer commented 5 years ago

Thank you for noticing this an opening an issue!

I'm not actively working on mathsteps right now, but am happy to help you make a PR to update this :)

Seems like there would need to be an update to the removeUnecessaryParens function, but that could be messy and break some other functionality. Would be interesting to explore!

Stumblefeet commented 5 years ago

Thanks.

I'm considering diving into the code and study it in depth.

Do you know if this project is still being developed, or is it dying/finished?

I'm looking for a large project to contribute to, and this seems rather nice.

evykassirer commented 5 years ago

I haven't been prioritizing much time on mathsteps lately, so it is some ways dying.

However, if you take a look through the code and would like me to answer some questions or help you contribute, I'd be happy to spend some time on that :)

ghost commented 5 years ago

@evykassirer I am personally interested in helping out. mathsteps should not die. It has tremendous value and potential ! Is there a priority list somewhere with things pending ?

evykassirer commented 5 years ago

the list of open issues is a good place to look for things pending!