search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 275 forks source link

Wrote helper function getRadicandNode #92

Closed lexiross closed 7 years ago

lexiross commented 7 years ago

Implemented helper function getRadicandNote and called it in place of accessing nodes.args[0] on nthRoot nodes.

Fixes #34

It looks like the other helper functions in the file (like getRootNode) don't have unit tests on them, but let me know if you'd like me to write them for this one!

evykassirer commented 7 years ago

Perfect! Thanks for taking this on :)

Yeah, probably easiest to not write tests for the helper functions (I think you'd have to export them in the module if you wanted to test them directly). All the things that use getRadicandNode have tests that are passing, so looks good to me!

Hope to see you on some other issues too! 😸 let me know if you have any questions

lexiross commented 7 years ago

@evykassirer yay, thanks for the merge! I'll look at the other issues for sure - excited to dig in and understand the code base more 💯