google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 275 forks source link

Handle division by 0 #97

Closed hmaurer closed 7 years ago

hmaurer commented 7 years ago

addresses #29

This PR adds a basic search strategy which generates a DIVISION_BY_ZERO step when encountering either */0 or 0/0. In the main loop (simplifyExpression/stepThrough.js) we then stop the simplification process if such a step is generated (since division by zero counts as a form of error).

evykassirer commented 7 years ago

hey @hmaurer how's this going?

evykassirer commented 7 years ago

@hmaurer wanna close this and start from scratch, or just update this PR?

hmaurer commented 7 years ago

Let's close it for now.